WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi

from [Jeremy Fitzhardinge] [Permanent Link][Original]
To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Mon, 19 Apr 2010 09:22:26 -0700
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Yu Zhiguo <yuzg@xxxxxxxxxxxxxx>
Delivery-date: Mon, 19 Apr 2010 09:23:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100419133026.GA17501@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BC7C657.3010609@xxxxxxxxxxxxxx> <20100416145604.GC29398@xxxxxxxxxxxxxxxxxxx> <4BCA82FF.20901@xxxxxxxxxxxxxx> <4BCA8E9A.6090209@xxxxxxxx> <20100419133026.GA17501@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.4 
On 04/19/2010 06:30 AM, Konrad Rzeszutek Wilk wrote:
>>> ...
>>>   
>>>       
>> This is a good way of handling it.
>>     
> The header file change or the #ifdef in the acpi/boot.c file?
>   

Adding stub static inlines is almost always preferable to open-coded
#ifdefs in .c files.  But we're growing a bit of an #ifdef thicket in
there...

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [Xen-devel] [PATCH 3/4] libxl: add version_info function [and 1 more messages], Ian Jackson
Next by Date:  Re: [Xen-devel] pci-passthrough not working on 4.0.1-rc1-pre: mm.c:3847:d10 Bad page 00000000001beab4: ed=ffff830151210000(10), sd=ffff830151210000, caf=8000000000000002, taf=7400000000000001, Konrad Rzeszutek Wilk
Previous by Thread:  Re: [Xen-devel] [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi, Konrad Rzeszutek Wilk
Next by Thread:  Re: [Xen-devel] [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi, Yu Zhiguo
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy