Re: [Xen-devel] [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

On 04/20/2010 08:29 PM, Yu Zhiguo wrote:
> We must use #if !defined(CONFIG_XEN) || (defined(CONFIG_XEN) && 
> !defined(CONFIG_XEN_DOM0_PCI)).
>   

CONFIG_XEN_DOM0_PCI depends on CONFIG_XEN, so there's no need to test
that separately, right?  "#ifndef CONFIG_XEN_DOM0_PCI" is enough.

> method-4)
> If we perfer to fix it in header file, another method, we can use weak 
> attribute of gcc.
>   

"weak" has its place, but I'm not sure its the right answer here.  The
main problem is that it is a link-time binding, so the generated code
still has the calls out to the functions.   With static inline
functions, the compiler will likely completely remove all the code.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel