WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi

To: Yu Zhiguo <yuzg@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Wed, 21 Apr 2010 09:31:59 -0700
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Wed, 21 Apr 2010 09:33:12 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BCE7120.7020004@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BC7C657.3010609@xxxxxxxxxxxxxx> <20100416145604.GC29398@xxxxxxxxxxxxxxxxxxx> <4BCA82FF.20901@xxxxxxxxxxxxxx> <4BCA8E9A.6090209@xxxxxxxx> <20100419133026.GA17501@xxxxxxxxxxxxxxxxxxx> <4BCD3C2B.3030706@xxxxxxxxxxxxxx> <20100420183301.GA32720@xxxxxxxxxxxxxxxxxxx> <4BCE7120.7020004@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.4
On 04/20/2010 08:29 PM, Yu Zhiguo wrote:
> We must use #if !defined(CONFIG_XEN) || (defined(CONFIG_XEN) && 
> !defined(CONFIG_XEN_DOM0_PCI)).
>   

CONFIG_XEN_DOM0_PCI depends on CONFIG_XEN, so there's no need to test
that separately, right?  "#ifndef CONFIG_XEN_DOM0_PCI" is enough.

> method-4)
> If we perfer to fix it in header file, another method, we can use weak 
> attribute of gcc.
>   

"weak" has its place, but I'm not sure its the right answer here.  The
main problem is that it is a link-time binding, so the generated code
still has the calls out to the functions.   With static inline
functions, the compiler will likely completely remove all the code.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>