Re: [Xen-devel] [PATCH] xen: Deal with stdarg.h and -nostdinc

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Christoph Egger writes ("[Xen-devel] [PATCH] xen: Deal with stdarg.h and 
-nostdinc"):
> For compiling the xen kernel we use -nostdinc which means
> we don't want to rely on any external headers.
> That also counts vor stdarg.h.

Right, OK, but:

> Use the external header when we compile the tools.
> Adapt libelf-loader.c which is compiled in the kernel
> and with the tools.

-#include <stdarg.h>
+#include "../../include/xen/stdarg.h"

Firstly, is this correct for all uses of libelf-loader ?  This file is
compiled both for use inside Xen and for use on the host.  In the
latter case it /should/ use the system's stdarg.h.

Also, this kind of relative path should not be necessary.  The
relevant files should be on the include path.

So I think this should be fixed by arranging that your new stdarg.h is
on the relevant include path, not by changing the .c file.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel