WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code

To: Horms <horms@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 17 Oct 2006 07:56:37 +0100
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, Kazuo Moriwaka <moriwaka@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>, magnus.damm@xxxxxxxxx, Isaku Yamahata <yamahata@xxxxxxxxxxxxx>, Magnus Damm <magnus@xxxxxxxxxxxxx>
Delivery-date: Tue, 17 Oct 2006 00:08:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061017012519.GH29719@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbxuWOqofs9il2sEduTVgANk04WTA==
Thread-topic: [PATCH 01/04] Kexec / Kdump: Generic code
User-agent: Microsoft-Entourage/11.2.5.060620


On 17/10/06 2:25 am, "Horms" <horms@xxxxxxxxxxxx> wrote:

> TYPE_DEFAULT is kexec, TYPE_CRASH is kdump.
> 
> Its just to avoid a from_guest. If you think that isn't worthwhile
> we can fold it into the structural parameter.

Yes please. This isn't performance critical. Folding will make the interface
better match other hypercalls.

> I certainly saw the problem. I'll do some more investigations.
> 
> ... Actually now that I think about it for a moment, perhaps it was
> inheriting -Wall from CFLAGS in my environment. If that is the case,
> then I think the work-around I added is valid.:wq

Xen is always built with -Wall. I simply don't believe this can be a valid
warning message. There's nothing special about __xchg() that should cause
complaint when its return value is discarded (a common thing to do in C).
Can you repro the problem on vanilla versions of gcc (straight from
gnu.org)?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel