WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: Xen 4.1 rc1 test report

To: "Wei, Gang" <gang.wei@xxxxxxxxx>, "Zheng, Shaohui" <shaohui.zheng@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: Xen 4.1 rc1 test report
From: Keir Fraser <keir@xxxxxxx>
Date: Wed, 26 Jan 2011 07:24:33 +0000
Cc:
Delivery-date: Tue, 25 Jan 2011 23:25:28 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=wqxAfA8lmRP5FW0xo9ycQVdcNV3Ct7TaWQBVrlYxITw=; b=jUf5fb2D11TX6f5O4zlCfg7x/agudqXFooCrpxuEJJQykvTgoc4WJehnm90S2/Gb4q iidU7hY7fZ/ivaIlI6L/bQCohOd17HupR5RwMcgAeXYj3rCWIEdNS68eG2s+MMWhmIMk 7fjro6GUeZ9L0Q2+3iKHavD4fCsfHHqpx/1po=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=xgdvpDt0XaRy32kM3X5ZQd/NQkpTcUX4ZSSqC8BW7zbjAQJ+BbyV1Uy+9Y2nyWL7yf sHVY1PVzOx/ozzC4spsKYjMMKlmlYz6mUv+uFqW3sHPczFnZ1hj8Ie1P9NeoHnpnyWDb W6qVaxG0M8jkh9EBHM9JP5iktQg6qrycqN4bU=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <F26D193E20BBDC42A43B611D1BDEDE712556378A03@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acu6GEBstpnTfIH/TdeQZvf0FjUZ0QAOlF+wAI5FPEAAJDXLMAABNBkQAAIxXhE=
Thread-topic: Xen 4.1 rc1 test report
User-agent: Microsoft-Entourage/12.28.0.101117
On 26/01/2011 06:31, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:

> Wei, Gang wrote on 2011-01-26:
>> Just found sometime while doing domain_destroy the current->domain is
>> IDLE domain, so the if ( !IS_PRIV_FOR(current->domain, d) ) hit and
>> skip the pirq forcible unbinding. How could it happen?
> 
> Look like it is caused by call_rcu(&d->rcu, complete_domain_destroy) in the
> end of domain_destroy fn. We may need to move the check for
> IS_PRIV_FOR(current->domain, d) out and check it earlier in the call path if
> necessary.

Those core map/unmap functions shouldn't be doing the priv checks
themselves. I'll sort out a patch for you to try.

 -- Keir

> Jimmy
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel