WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code

To: Horms <horms@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 18 Oct 2006 08:13:49 +0100
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, Kazuo Moriwaka <moriwaka@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, magnus.damm@xxxxxxxxx, Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>, Isaku Yamahata <yamahata@xxxxxxxxxxxxx>, Magnus Damm <magnus@xxxxxxxxxxxxx>
Delivery-date: Wed, 18 Oct 2006 00:25:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061018005637.GB11422@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbyhPUyM94u/F54EdupPAANk04WTA==
Thread-topic: [Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code
User-agent: Microsoft-Entourage/11.2.5.060620
On 18/10/06 1:56 am, "Horms" <horms@xxxxxxxxxxxx> wrote:

>> I'll check this in, so please just get rid of the if(xchg()) hacky
>> workaround.
> 
> I have to say that I entirely disagree with your solution.
> I think the solution is to get rid of -Werror. But I will
> remove the if(xchg()) foo as you request.

Holy crap! Getting rid of Werror makes Wall much less useful. We're too lazy
to scan build output for warnings if they don't break the build.

The GCC developers have basically broken the unused-value checking, at least
for Linux-style code which is heavy on macro usage. If a particular warning
option is no longer useful, the correct answer is to switch it off.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>