WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code
From: Horms <horms@xxxxxxxxxxxx>
Date: Wed, 18 Oct 2006 10:00:05 +0900
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, Kazuo Moriwaka <moriwaka@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>, magnus.damm@xxxxxxxxx, Isaku Yamahata <yamahata@xxxxxxxxxxxxx>, Magnus Damm <magnus@xxxxxxxxxxxxx>
Delivery-date: Thu, 19 Oct 2006 09:25:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C15A3D35.29F0%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061017012519.GH29719@xxxxxxxxxxxx> <C15A3D35.29F0%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: mutt-ng/devel-r804 (Debian)
On Tue, Oct 17, 2006 at 07:56:37AM +0100, Keir Fraser wrote:
> 
> 
> 
> On 17/10/06 2:25 am, "Horms" <horms@xxxxxxxxxxxx> wrote:
> 
> > TYPE_DEFAULT is kexec, TYPE_CRASH is kdump.
> > 
> > Its just to avoid a from_guest. If you think that isn't worthwhile
> > we can fold it into the structural parameter.
> 
> Yes please. This isn't performance critical. Folding will make the interface
> better match other hypercalls.

The main thing that I am concerned about is, that in the
case that dom0 panics, and we are asking the hypercall to take a dump
for us, do we really want a copy_from guest in that path?
It seems to me that its best to have that path as simple as possible.
But I do argree that it comes at the expense of making the interface
a bit unclean.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel