| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code
|
To: |
Magnus Damm <magnus@xxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code |
|
From: |
Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
|
Date: |
Mon, 16 Oct 2006 15:03:29 +0100 |
|
Cc: |
Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, Kazuo Moriwaka <moriwaka@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>, magnus.damm@xxxxxxxxx, Isaku Yamahata <yamahata@xxxxxxxxxxxxx>, Horms <horms@xxxxxxxxxxxx> |
|
Delivery-date: |
Mon, 16 Oct 2006 07:04:07 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20061016083324.7611.3312.sendpatchset@localhost> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
AcbxK9sxGd60rl0fEduyIAAX8io7RQ== |
|
Thread-topic: |
[PATCH 01/04] Kexec / Kdump: Generic code |
|
User-agent: |
Microsoft-Entourage/11.2.5.060620 |
Some comments:
No need for IO-APIC work on the guest side of the kexec interfaces (e.g.,
don't call disable_IO_APIC()).
What's the second argument to the hypercall for? There's no clear
explanation of what the TYPE parameter means, and currently it is only ever
specified as TYPE_CRASH. So what's TYPE_DEFAULT for? And do we really need
to avoid copy_to/from_guest so it can't be folded into the structural
parameter?
The comment attached to every use of xchg() is dubious. We don't specify
warn_unused_result on that function so there's no good reason for the
compiler to complain about discarding the result. If it's a reproducible
problem it needs investigating. We shouldn't work around a broken compiler.
Attribution at the top of many files: 'Horms' is a bit vague. Could we have
a full name? A company name? An email address?
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home