WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

[Xen-devel] Re: [RFC PATCH 00/35] Xen i386 paravirtualization support

from [Martin J. Bligh] [Permanent Link][Original]
To: Chris Wright <chrisw@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [RFC PATCH 00/35] Xen i386 paravirtualization support
From: "Martin J. Bligh" <mbligh@xxxxxxxxxx>
Date: Tue, 09 May 2006 07:49:37 -0700
Cc: virtualization@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
Delivery-date: Wed, 10 May 2006 04:47:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060509084945.373541000@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060509084945.373541000@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.7 (X11/20051013) 
Congrats on getting this thrashed out. A few comments, most of which are
boring style nits, but nonetheless ... will try to take a proper look
later.

General comment:

Why is this style used:

HYPERVISOR_foo_bar ?

ie the capitalization of HYPERVISOR. Doesn't seem to fit with the rest
of the kernel style.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  [Xen-devel] Re: [RFC PATCH 35/35] Add Xen virtual block device driver., Christoph Hellwig
Next by Date:  [Xen-devel] Re: [RFC PATCH 15/35] subarch support for controlling interrupt delivery, Martin J. Bligh
Previous by Thread:  [Xen-devel] [RFC PATCH 10/35] Add a new head.S start-of-day file for booting on Xen., Chris Wright
Next by Thread:  [Xen-devel] Re: [RFC PATCH 00/35] Xen i386 paravirtualization support, Christoph Hellwig
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy