[Xen-devel] Re: [RFC PATCH 00/35] Xen i386 paravirtualization support

[Andi Kleen <ak@xxxxxxx>]

Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:

> On Tue, May 09, 2006 at 07:49:37AM -0700, Martin J. Bligh wrote:
> > Congrats on getting this thrashed out. A few comments, most of which are
> > boring style nits, but nonetheless ... will try to take a proper look
> > later.
> > 
> > General comment:
> > 
> > Why is this style used:
> > 
> > HYPERVISOR_foo_bar ?
> > 
> > ie the capitalization of HYPERVISOR. Doesn't seem to fit with the rest
> > of the kernel style.
> 
> It's also wrong.  There's more than one hypervisor and Xen shouldn't just
> grab this namespace.  make it xen_ or xenhv_.

You should reject the recent "hypervisor file system" with the same
argument then.

-Andi

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel