WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] USB virt 2.6 split driver patch series

To: Anthony Liguori <aliguori@xxxxxxxxxx>
Subject: Re: [Xen-devel] USB virt 2.6 split driver patch series
From: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx>
Date: Tue, 22 Nov 2005 21:27:00 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, NAHieu <nahieu@xxxxxxxxx>, harry <harry@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>, Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx>
Delivery-date: Tue, 22 Nov 2005 20:26:59 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <43833B4E.8070502@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1132586050.31295.145.camel@xxxxxxxxxxxxxxxxxxxxx> <5d7aca950511210727i741148efl71f025577680d994@xxxxxxxxxxxxxx> <1132587554.31295.154.camel@xxxxxxxxxxxxxxxxxxxxx> <5d7aca950511210902j5002bbfdxe52b1a32517d6c8b@xxxxxxxxxxxxxx> <1132593451.31295.171.camel@xxxxxxxxxxxxxxxxxxxxx> <5d7aca950511211759i63ed353al8f95ea411bbd49ff@xxxxxxxxxxxxxx> <5d7aca950511211800j9799a2dy3186ef4133213417@xxxxxxxxxxxxxx> <1132655069.5956.5.camel@xxxxxxxxxxxxxxxxxxxxx> <20051122110710.GA29624@xxxxxxxxx> <43833B4E.8070502@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Tue, Nov 22, 2005 at 09:37:50AM -0600, Anthony Liguori wrote:
> Harry's right, it's not allowed by the C standard.

still this is common accepted practice is kernel code ...
(no glibc included/linked, gcc specific)

> FWIW, I don't think it's all that common to use underscores to denote 
> functions as private when you can just mark them static.

grep "__[a-z]" | grep "EXPORT" in linux kernel source you'll be surprise.

most kernels-code reason to provide both function (__fctname and fctname) is:
- one is lock free, the other lock what is necessary.
- one test some conditions, the other doesn't

and probably some others reasons ..

Cheers,
-- 
Vincent Hanquez

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>