|
|
|
|
|
|
|
|
|
|
xen-devel
Re: [Xen-devel] USB virt 2.6 split driver patch series
On Mon, Nov 21, 2005 at 03:14:10PM +0000, harry wrote:
> Lindent also messed up by putting the starting open brace for a number
> of functions after the parameters rather than at the start of a new
> line. There are also some problems from Lindent with parameter lists
> being formatted in a confusing way. I need to go through and fix these
> issues. I thought it was more important to get the code out for more
> exposure and feedback on other issues than hide it away for another week
> to fix the formatting perfectly.
The thing is, the more readable the coding style, the more meaningful
comments you'll get. I believe readable in this context is the Linux
kernel coding style. Case in point - all of the comments so far have
been about the coding style. Please fix it as soon as possible and
repost so that we could move on to more substantial issues without
getting hung up on the awkward (from a Linux kernel POV!) coding
style.
Cheers,
Muli
--
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
<Prev in Thread] |
Current Thread |
[Next in Thread>
|
- Re: [Xen-devel] USB virt 2.6 split driver patch series, (continued)
- Re: [Xen-devel] USB virt 2.6 split driver patch series, NAHieu
- Re: [Xen-devel] USB virt 2.6 split driver patch series, harry
- Re: [Xen-devel] USB virt 2.6 split driver patch series, NAHieu
- Re: [Xen-devel] USB virt 2.6 split driver patch series, harry
- Re: [Xen-devel] USB virt 2.6 split driver patch series, NAHieu
- Re: [Xen-devel] USB virt 2.6 split driver patch series, NAHieu
- Re: [Xen-devel] USB virt 2.6 split driver patch series, harry
- Re: [Xen-devel] USB virt 2.6 split driver patch series, Vincent Hanquez
- Re: [Xen-devel] USB virt 2.6 split driver patch series, Anthony Liguori
- Re: [Xen-devel] USB virt 2.6 split driver patch series, Vincent Hanquez
- Re: [Xen-devel] USB virt 2.6 split driver patch series,
Muli Ben-Yehuda <=
- Re: [Xen-devel] USB virt 2.6 split driver patch series, Harry Butterworth
- Re: [Xen-devel] USB virt 2.6 split driver patch series, Muli Ben-Yehuda
- Re: [Xen-devel] USB virt 2.6 split driver patch series, harry
- Re: [Xen-devel] USB virt 2.6 split driver patch series, Oleg Goldshmidt
- Re: [Xen-devel] USB virt 2.6 split driver patch series, harry
Re: [Xen-devel] USB virt 2.6 split driver patch series, Dave Feustel
|
|
|
|
|