[Xen-devel] Re: [PATCH] xen: Disable stack protector for irq helper

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

On 10/04/09 18:35, Bastian Blank wrote:
> On Sun, Oct 04, 2009 at 04:06:13PM -0700, Jeremy Fitzhardinge wrote:
>   
>> On 10/04/09 11:30, Bastian Blank wrote:
>>     
>>> The stack protector needs additional registers on x86_32, which are not
>>> saved in calls to the small paravirt interrupt handlers. This leads to
>>> early crashes as registers are overwritten and not saved by the caller
>>> as instructed.
>>>       
>> Thanks for the patch, but I don't think its quite right.  
>> PV_CALLEE_SAVE_REGS_THUNK() is responsible for generating a wrapper for
>> the functions to save/restore all the appropriate registers.  If it is
>> failing to do so, then the correct fix is to update
>> PV_SAVE/RESTORE_ALL_CALLER_REGS.
>>     
> Well, I did not understand this part of the code, but you seem right. So
> lets try the following. I have not yet run tested it.
>
> Save all caller-saved registers on x86_32 for the paravirt callee saved
> registers.
>   

That looks better, but it is still overkill.  We only need to save the
set of registers the ABI requires the callee to preserve.  What
additional register(s) gets clobbered by stack-protector that need to be
saved?

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel