WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] xen: Disable stack protector for irq helper

To: Ingo Molnar <mingo@xxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] xen: Disable stack protector for irq helper
From: Bastian Blank <bastian@xxxxxxxxxxxx>
Date: Mon, 12 Oct 2009 23:12:58 +0200
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Stable Kernel <stable@xxxxxxxxxx>
Delivery-date: Mon, 12 Oct 2009 14:12:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20091012205208.GE17163@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Bastian Blank <bastian@xxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Stable Kernel <stable@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
References: <4AC92A65.40806@xxxxxxxx> <20091005013517.GA6081@xxxxxxxxxxxxxxxxxxxxxxx> <4ACA2AFD.4080305@xxxxxxxx> <20091005224310.GA32144@xxxxxxxxxxxxxxxxxxxxxxx> <4ACA90F2.1060909@xxxxxxxx> <20091006033050.GA6332@xxxxxxxxxxxxxxxxxxxxxxx> <4ACB93F8.5010900@xxxxxxxx> <20091007163521.GA17998@xxxxxxxxxxxxxxxxxxxxxxx> <4ACD3346.3010307@xxxxxxxx> <20091012205208.GE17163@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Oct 12, 2009 at 10:52:08PM +0200, Ingo Molnar wrote:
> ping - any update about this fix? Since it fixes a real crash it would 
> be nice to fix this for .32.

It works nicely.

But IMHO this whole infrastructure should go for now, at least until gcc
is able to produce functions with this call convention on its own. Or it
needs to be restricted to only assembler functions. The other users of
this may only work because the stack protector is already disabled for
arch/x86/xen/mmu.o.

Bastian

-- 
Men will always be men -- no matter where they are.
                -- Harry Mudd, "Mudd's Women", stardate 1329.8

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>