|   | 
      | 
  
  
      | 
      | 
  
 
     | 
    | 
  
  
     | 
    | 
  
  
    |   | 
      | 
  
  
    | 
         
xen-devel
[Xen-devel] [PATCH] xen: Disable stack protector for irq helper
 
| 
To:  | 
Ingo Molnar <mingo@xxxxxxxxxx> | 
 
| 
Subject:  | 
[Xen-devel] [PATCH] xen: Disable stack protector for irq helper | 
 
| 
From:  | 
Bastian Blank <bastian@xxxxxxxxxxxx> | 
 
| 
Date:  | 
Sun, 4 Oct 2009 20:30:13 +0200 | 
 
| 
Cc:  | 
Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>,	Jeremy Fitzhardinge <jeremy@xxxxxxxx>,	the arch/x86 maintainers <x86@xxxxxxxxxx>,	Stable Kernel <stable@xxxxxxxxxx>,	Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx> | 
 
| 
Delivery-date:  | 
Sun, 04 Oct 2009 11:30:08 -0700 | 
 
| 
Envelope-to:  | 
www-data@xxxxxxxxxxxxxxxxxxx | 
 
| 
List-help:  | 
<mailto:xen-devel-request@lists.xensource.com?subject=help> | 
 
| 
List-id:  | 
Xen developer discussion <xen-devel.lists.xensource.com> | 
 
| 
List-post:  | 
<mailto:xen-devel@lists.xensource.com> | 
 
| 
List-subscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> | 
 
| 
List-unsubscribe:  | 
<http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> | 
 
| 
Mail-followup-to:  | 
Bastian Blank <bastian@xxxxxxxxxxxx>,	Ingo Molnar <mingo@xxxxxxxxxx>,	Jeremy Fitzhardinge <jeremy@xxxxxxxx>,	the arch/x86 maintainers <x86@xxxxxxxxxx>,	Stable Kernel <stable@xxxxxxxxxx>,	Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>,	Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx> | 
 
| 
Sender:  | 
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx | 
 
| 
User-agent:  | 
Mutt/1.5.18 (2008-05-17) | 
 
 
 
The stack protector needs additional registers on x86_32, which are not
saved in calls to the small paravirt interrupt handlers. This leads to
early crashes as registers are overwritten and not saved by the caller
as instructed.
Signed-off-by: Bastian Blank <waldi@xxxxxxxxxx>
diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
index 3bb4fc2..ac19398 100644
--- a/arch/x86/xen/Makefile
+++ b/arch/x86/xen/Makefile
@@ -5,9 +5,9 @@
 CFLAGS_REMOVE_irq.o = -pg
 endif
 
-# Make sure early boot has no stackprotector
 nostackp := $(call cc-option, -fno-stack-protector)
 CFLAGS_enlighten.o             := $(nostackp)
+CFLAGS_irq.o                   := $(nostackp)
 CFLAGS_mmu.o                   := $(nostackp)
 
 obj-y          := enlighten.o setup.o multicalls.o mmu.o irq.o \
-- 
Mind your own business, Spock.  I'm sick of your halfbreed interference.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 
 |   
 
| <Prev in Thread] | 
Current Thread | 
[Next in Thread>
 |  
- [Xen-devel] [PATCH] xen: Disable stack protector for irq helper,
Bastian Blank <=
 
 
 |  
  
 | 
    | 
  
  
    |   | 
    |