This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits

To: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 29 Apr 2009 22:23:01 +0100
Delivery-date: Wed, 29 Apr 2009 14:23:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1241029092.5394.178.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnI9uQ96r7vXCqQTg+KlLzJCXafIwAGchoU
Thread-topic: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits
User-agent: Microsoft-Entourage/
On 29/04/2009 19:18, "Tim Post" <echo@xxxxxxxxxxxx> wrote:

> Someone using xs.h is going to be entirely unaware of said limits.
> Xenstore internals will relay an appropriate errno if the limits are
> exceeded, but I think many people will not know such limits exist.
> Xenwire is used when developing drivers.. not user space applications.
> Why not assert the limits in both at the cost of bothering the
> preprocessor three times?

Defining the same thing again but with a different name just for purposes of
documentation is pretty barking. I suppose it is perhaps worth a
documentation comment in xs.h, but no more than that.

 -- Keir

Xen-devel mailing list