This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits
From: Tim Post <echo@xxxxxxxxxxxx>
Date: Thu, 30 Apr 2009 16:54:51 +0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 30 Apr 2009 01:56:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C61E83C5.9D20%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C61E83C5.9D20%keir.fraser@xxxxxxxxxxxxx>
Reply-to: echo@xxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2009-04-29 at 22:23 +0100, Keir Fraser wrote:
> On 29/04/2009 19:18, "Tim Post" <echo@xxxxxxxxxxxx> wrote:
> > Someone using xs.h is going to be entirely unaware of said limits.
> > Xenstore internals will relay an appropriate errno if the limits are
> > exceeded, but I think many people will not know such limits exist.
> > 
> > Xenwire is used when developing drivers.. not user space applications.
> > 
> > Why not assert the limits in both at the cost of bothering the
> > preprocessor three times?
> Defining the same thing again but with a different name just for purposes of
> documentation is pretty barking. I suppose it is perhaps worth a
> documentation comment in xs.h, but no more than that.

It is worth a mention... though it seems silly to send a patch that adds
comments. However, a patch that would convert the comments in xs to
doxygen format seems more useful, with the appropriate grouping, shorts,

How receptive would you be to that?


Xen-devel mailing list