This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits
From: Tim Post <echo@xxxxxxxxxxxx>
Date: Thu, 30 Apr 2009 18:02:54 +0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 30 Apr 2009 03:03:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C61F2F65.9D53%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C61F2F65.9D53%keir.fraser@xxxxxxxxxxxxx>
Reply-to: echo@xxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2009-04-30 at 10:35 +0100, Keir Fraser wrote:
> On 30/04/2009 09:54, "Tim Post" <echo@xxxxxxxxxxxx> wrote:
> >> Defining the same thing again but with a different name just for purposes 
> >> of
> >> documentation is pretty barking. I suppose it is perhaps worth a
> >> documentation comment in xs.h, but no more than that.
> > 
> > It is worth a mention... though it seems silly to send a patch that adds
> > comments. However, a patch that would convert the comments in xs to
> > doxygen format seems more useful, with the appropriate grouping, shorts,
> > etc.
> > 
> > How receptive would you be to that?
> I don't have a strong opinion. You can go wild on that if you like, assuming
> noone else hates doxygen format for any reason. I added a limits-related
> comment to xs.h by the way.

Well, since we have doxygen in the build, and the generated html docs
are so easy to read .. seems sort of silly not to make it uniform :)

If nobody replies with a resounding PLEASE NO, I'll go ahead and do
it .. libxc needs some comment love anyway.

It is very frustrating and difficult for people to write apps that work
with Xen using the shipped (or wiki) documentation. All too often,
what's on the wiki is not in step with unstable, so each new release is
like an easter egg hunt.

I also have some autoconf macros that I'll post to help stop breakage
due to structures shifting members. from the earlier days of v3 (but
still in use).


Xen-devel mailing list