This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 1/1 Better expose xenstore limits
From: Tim Post <echo@xxxxxxxxxxxx>
Date: Thu, 30 Apr 2009 02:18:12 +0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 29 Apr 2009 11:18:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C61E5492.9BE4%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C61E5492.9BE4%keir.fraser@xxxxxxxxxxxxx>
Reply-to: echo@xxxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2009-04-29 at 19:01 +0100, Keir Fraser wrote:
> On 29/04/2009 17:43, "Tim Post" <echo@xxxxxxxxxxxx> wrote:
> > Since xs.h already includes xs_wire, this patch duplicates those limits
> > would be a pain, but they really need to be advertised.
> > 
> > Such limits should be obvious in the headers that people actually use
> > outside of the kernel, saving them from wondering what went wrong.
> > 
> > Added comments direct people to xs_wire.h , in case those limits change.
> In terms of documentation, docs/misc/xenstore.txt already does a fine job.

Provided such docs are actually packaged.. many install Xen (and
associated DSO's and headers) via yum, apt-get, etc.

> And I think a xen/public/... header is the right place for the limits, since
> it is a general documented protocol-level constraint, rather than a
> constraint of the particular client library (which is the scope of xs.h
> itself).

Yes, it is the right place for the limits, the patch does not suggest
moving them, only echoing them in the header that user space apps will

Someone using xs.h is going to be entirely unaware of said limits.
Xenstore internals will relay an appropriate errno if the limits are
exceeded, but I think many people will not know such limits exist.

Xenwire is used when developing drivers.. not user space applications.

Why not assert the limits in both at the cost of bothering the
preprocessor three times?


Xen-devel mailing list