This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen

To: Andi Kleen <ak@xxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 16 May 2006 14:03:19 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ryan Grimm <grimm@xxxxxxxxxx>, Ryan Harper <ryanh@xxxxxxxxxx>
Delivery-date: Tue, 16 May 2006 06:03:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200605161457.09187.ak@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060501215648.GU16776@xxxxxxxxxx> <200605152246.30374.ak@xxxxxxx> <25076f74e546e868c489e384ee838e2e@xxxxxxxxxxxx> <200605161457.09187.ak@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 16 May 2006, at 13:57, Andi Kleen wrote:

Yes, my gut feeling looking at x86_64's numa.c is that it's going to
need some heavier surgery than srat.c. I wouldn't worry so much about
keeping that one close to the Linux original: if we end up pulling down more Linux memory bookkeeping code later then we can always go back and
sync the file more closely. Keep it as clean as possible though,
obviously (e.g., replacing whole functions is nicer than functions that
are a hacky halfway house between Linux and Xen, etc).

If it helps I can split these functions into smaller ones in the mainline
sources. That could isolate the pglists in only very small functions.

Thanks: I guess we'll see how the new patch turns out. It would certainly be very useful if you could glance over the next revision of the NUMA patches -- at least the first one of the set which will be the one that takes code from x86/64 Linux. I'm certain you'll be able to pick up on details that I wouldn't spot.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>