This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen
From: Ryan Harper <ryanh@xxxxxxxxxx>
Date: Wed, 17 May 2006 12:21:24 -0500
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Andi Kleen <ak@xxxxxxx>, Ryan Grimm <grimm@xxxxxxxxxx>
Delivery-date: Wed, 17 May 2006 10:22:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <25076f74e546e868c489e384ee838e2e@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060501215648.GU16776@xxxxxxxxxx> <dd8e79fae1047be14919a2432d163d28@xxxxxxxxxxxx> <20060515203242.GM16876@xxxxxxxxxx> <200605152246.30374.ak@xxxxxxx> <25076f74e546e868c489e384ee838e2e@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
* Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> [2006-05-16 02:54]:
> On 15 May 2006, at 21:46, Andi Kleen wrote:
> >>What I'm fighting now is getting linux/arch/x86_64/mm/numa.c to build.
> >>Some of the structures to track numa info (struct pglist_data) are
> >>rather linux specific and include lots of structures related to Linux 
> >>mm
> >>zones, check out linux/include/linux/mmzone.h.  I attempted to avoid
> >>bring in that in, but the pfn_to_nid/phys_to_nid macros are based on
> >>memnodemap array.
> >
> >
> >I guess you can just replace setup_node_bootmem / setup_node_zones /
> >numa_free_all_bootmem with Xen specific functions. They should be the 
> >only
> >functions dealing with pglists and they're relatively straight forward.
> Yes, my gut feeling looking at x86_64's numa.c is that it's going to 
> need some heavier surgery than srat.c. I wouldn't worry so much about 
> keeping that one close to the Linux original: if we end up pulling down 
> more Linux memory bookkeeping code later then we can always go back and 
> sync the file more closely. Keep it as clean as possible though, 
> obviously (e.g., replacing whole functions is nicer than functions that 
> are a hacky halfway house between Linux and Xen, etc).

Is there an equivalent function in Xen for
linux/arch/x86_64/kernel/e820.c:find_e820_area() ?

I'm looking at linux/arch/x86_64/mm/numa.c:setup_node_bootmem() and as I
understand, it finds a free location in the e820 map within a node's
bounds to place the struct pglist_data which will hold node information.

Is this something we should do in Xen, or can we just have a static
array of structures which hold the node information?

Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253

Xen-devel mailing list