This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen

To: Ryan Harper <ryanh@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen
From: Andi Kleen <ak@xxxxxxx>
Date: Mon, 22 May 2006 13:01:30 +0200
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ryan Grimm <grimm@xxxxxxxxxx>
Delivery-date: Mon, 22 May 2006 04:02:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060519210857.GR16876@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060501215648.GU16776@xxxxxxxxxx> <403a4dbd4c7329e3de93e78054d5ffaf@xxxxxxxxxxxx> <20060519210857.GR16876@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.1
> The patch is function on 32-bit and 64-bit boxes and parse the SRAT
> table and fills out the node_data array.  I installed a simple
> keyhandler 'u' to dump the info to check that it was function after
> booting up.

It mostly looks reasonable. As Keir noted you seem to have a lot of unnecessary
changes (printk->DPRINTK, white space etc.)

I would also suggest you keep the numa emulation. It's useful for debugging
so that developers without numa machines can reproduce numa issues.


Xen-devel mailing list