This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen

On 15 May 2006, at 18:17, Keir Fraser wrote:

When I looked at the x86_64 NUMA code, I noticed that SRAT parsing was
done by ACPI_NUMA (drivers/acpi/numa.c).  That code requires more ACPI
support than Xen currently has available. Rather than pulling in all of
that ACPI, I chose to start with the i386 SRAT table parser which was
sufficient for both i386 and x86_64.  I would think that using the
modified i386 srat.c for parser gets the job done without bringing in
all of the support needed to compile drivers/acpi/numa.c in Xen.

How about putting the two together: use the i386 SRAT parser and the
x86_64 srat.c for structures and initialization?

I guess it depends how cleanly it can be done. Can we use the x86/64 logic pretty much unmodified, but then pull in bits of the i386 parsing code as functions that the x86/64 code calls rather than the full-blown acpi routines it would usually call into? Or would it be possible to pull in drivers/acpi/numa.c without also having to pull in all 80kloc+ of acpi crap? This probably needs some thought and/or experimentation!

Option (b) looks plausible actually. After all, SRAT and SLIT are both static tables so they shouldn't need the full AML machinery. afaics acpi/numa.c mostly makes use of the acpi_table_parse*() family of functions, which we do (to some extent) already support in Xen.

I'd go for pulling in the acpi/numa.c file and see how far you can run with that.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>