This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] Re: [PATCH 1/6][RESEND] xen: Add NUMA support to Xen
From: Ryan Harper <ryanh@xxxxxxxxxx>
Date: Wed, 31 May 2006 13:06:29 -0500
Cc: Ryan Grimm <grimm@xxxxxxxxxx>, Andi Kleen <ak@xxxxxxx>
Delivery-date: Wed, 31 May 2006 11:08:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060524190222.GC1694@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060501215648.GU16776@xxxxxxxxxx> <403a4dbd4c7329e3de93e78054d5ffaf@xxxxxxxxxxxx> <20060519210857.GR16876@xxxxxxxxxx> <200605221301.30662.ak@xxxxxxx> <20060524190222.GC1694@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
* Ryan Harper <ryanh@xxxxxxxxxx> [2006-05-24 14:02]:
> * Andi Kleen <ak@xxxxxxx> [2006-05-22 06:02]:
> > 
> > > The patch is function on 32-bit and 64-bit boxes and parse the SRAT
> > > table and fills out the node_data array.  I installed a simple
> > > keyhandler 'u' to dump the info to check that it was function after
> > > booting up.
> > 
> > It mostly looks reasonable. As Keir noted you seem to have a lot of 
> > unnecessary
> > changes (printk->DPRINTK, white space etc.)
> Cleaned up.
> > 
> > I would also suggest you keep the numa emulation. It's useful for debugging
> > so that developers without numa machines can reproduce numa issues.
> Added numa emulation back in.  I've set it up such that if we fail to
> find a numa-node we fallback on to emulation of one node.  This allows
> the allocator code to not be filled with CONFIG_NUMA ifdefs as Keir
> wanted. 

This last patch didn't have a functional cpu_to_node/node_to_cpumask.
This patch fixes that up in addition to the previous cleanups.  Please
take a look.

Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253

Attachment: acpi_numa.tgz
Description: GNU Unix tar archive

Xen-devel mailing list