WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

Re: [Xen-ia64-devel] PATCH [resend]: more case handled in mmio.c

To: "Xu, Anthony" <anthony.xu@xxxxxxxxx>, <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>, "Alex Williamson" <alex.williamson@xxxxxx>
Subject: Re: [Xen-ia64-devel] PATCH [resend]: more case handled in mmio.c
From: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Date: Fri, 21 Apr 2006 10:22:37 +0200
Delivery-date: Fri, 21 Apr 2006 01:18:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <2BF508F394C196468CCBEC031320DCDF3809F7@pdsmsx405>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <2BF508F394C196468CCBEC031320DCDF3809F7@pdsmsx405>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.5
Le Vendredi 21 Avril 2006 10:01, Xu, Anthony a écrit :
> From: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
>
> >[mailto:xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Xu,
> > Anthony Sent: 2006?4?21? 15:55
> >To: Tristan Gingold; xen-ia64-devel@xxxxxxxxxxxxxxxxxxx; Alex Williamson
> >Subject: RE: [Xen-ia64-devel] PATCH [resend]: more case handled in mmio.c
> >
> >>From: Tristan Gingold [mailto:Tristan.Gingold@xxxxxxxx]
> >>Sent: 2006?4?21? 15:53
> >>To: Xu, Anthony; xen-ia64-devel@xxxxxxxxxxxxxxxxxxx; Alex Williamson
> >>Subject: Re: [Xen-ia64-devel] PATCH [resend]: more case handled in mmio.c
> >>
> >>Le Vendredi 21 Avril 2006 09:45, Xu, Anthony a écrit :
> >>> One more comment.
> >>>         /* Write high word.
> >>>                 FIXME: this is a kludge!  */
> >>>              v.u.bits[1] &= 0x3ffff;
> >>> This seems not be necessary.
> >>> v is got by stf.spill,
> >>> stf.spill makes sure the high 47 bits of v.u.bits[1] is 0.
> >>
> >>Yes, this is correct.
> >>In fact the comment is not correctly placed: the kludge is to do two
> >>mmio_access.
> >
> >The largest size of mmio is 8 byte, if not using pointer in ioreq
> > structure. And I don't know whether pointer works.
> >Is that possible to change "uint64_t data" to "long long data"?
> >Long long type is 16 byte, which is largest size of mmio in ia64.
>
> Sorry, long long type is still 8 byte.
> Do you know which type is 16 byte in ia64?
I don't think such a type exists on gcc/ia64.  Maybe a vector type ?
I think it is better to use a struct.

Tristan.



_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel