RE: [Xen-ia64-devel] PATCH [resend]: more case handled in mmio.c

["Xu, Anthony" <anthony.xu@xxxxxxxxx>]

>From: Tristan Gingold 
>Sent: 2006?4?21? 16:05
>To: Xu, Anthony; xen-ia64-devel@xxxxxxxxxxxxxxxxxxx; Alex Williamson
>Subject: Re: [Xen-ia64-devel] PATCH [resend]: more case handled in mmio.c
>
>Le Vendredi 21 Avril 2006 09:55, Xu, Anthony a écrit :
>> From: Tristan Gingold [mailto:Tristan.Gingold@xxxxxxxx]
>>
>> >Sent: 2006?4?21? 15:53
>> >To: Xu, Anthony; xen-ia64-devel@xxxxxxxxxxxxxxxxxxx; Alex Williamson
>> >Subject: Re: [Xen-ia64-devel] PATCH [resend]: more case handled in mmio.c
>> >
>> >Le Vendredi 21 Avril 2006 09:45, Xu, Anthony a écrit :
>> >> One more comment.
>> >>         /* Write high word.
>> >>                 FIXME: this is a kludge!  */
>> >>              v.u.bits[1] &= 0x3ffff;
>> >> This seems not be necessary.
>> >> v is got by stf.spill,
>> >> stf.spill makes sure the high 47 bits of v.u.bits[1] is 0.
>> >
>> >Yes, this is correct.
>> >In fact the comment is not correctly placed: the kludge is to do two
>> >mmio_access.
>>
>> The largest size of mmio is 8 byte, if not using pointer in ioreq
>> structure. And I don't know whether pointer works.
>> Is that possible to change "uint64_t data" to "long long data"?
>> Long long type is 16 byte, which is largest size of mmio in ia64.
>Yes, but this affects x86 too.
>
Yes, we need to make x86 work too.
Maybe x86 has similar issue. I'll find out. :-)

Thanks,
Anthony

>Tristan.

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel