WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xen

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xenstored_core.c
From: Keir Fraser <keir@xxxxxxx>
Date: Fri, 20 May 2011 09:41:34 +0100
Cc: Olaf Hering <olaf@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 20 May 2011 01:42:20 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to:cc :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=bkns1HX/eHFX5nlAuSuGGiCqqTQjNWVZmcTRdMhQ1KQ=; b=N36AfQL8Rd10V3Yxe+aXv+Z9iHse7CsFf53DPM/KVxN1ZpjnnQIqO7CtUd/6ZN2ytq 4Pq2K2wHQYK6wh0P8bGEnVYB/BJIYqnZRIrE4HT5jVW/A3kMR/z700Vx25fkBMALnxH/ 4jBgTg7fE5Qpqz9uHNjVf7Tal81H9BxP/JM30=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=b0UHs+qdC3pTqUz8qvqsC+7Xjovim/SIvoxLjPgG8dyDgepT7TDgUr/OflI8Ku0W5r w2p2MIDkTJ4HW0gd/HtnBCoe4VTeO44pVCFYF+Wnlt7XENjFMUPVTy2ByPl0xwzFslAG 0lQxB62dYghWsVhMpfTUsv5+B2plfHw597wx8=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1305880225.20576.2.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwWyblNvMjM/J3zK0ypxm3xHanOXw==
Thread-topic: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xenstored_core.c
User-agent: Microsoft-Entourage/12.29.0.110113
On 20/05/2011 09:30, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote:

>> I applied the first couple of these patches, but... We don't set
>> -Werror=unused-but-set-variable, so we don't actually need these fixes, do
>> we? Unless they are cleanups or fixes in some other way?
> 
> gcc 4.6 adds it to the default set of Werrors.

I'll take a patch from someone to remove it from the default set, please.
Until plenty of people are using gcc 4.6, it'll only get broken again and
again anyway, even if we applied all the current fixes.

I've applied all the patches that I considered nice cleanups, I'd like to
drop the rest.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>