Re: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xenstored_core.c

[Keir Fraser <keir@xxxxxxx>]

On 20/05/2011 15:38, "Olaf Hering" <olaf@xxxxxxxxx> wrote:

> On Fri, May 20, Keir Fraser wrote:
> 
>> On 20/05/2011 09:30, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote:
>> 
>>>> I applied the first couple of these patches, but... We don't set
>>>> -Werror=unused-but-set-variable, so we don't actually need these fixes, do
>>>> we? Unless they are cleanups or fixes in some other way?
>>> 
>>> gcc 4.6 adds it to the default set of Werrors.
>> 
>> I'll take a patch from someone to remove it from the default set, please.
> 
> I will send a tested patch.
> 
> It may hide some bugs. In one of the patches for tools/ some function
> returns 0 unconditionally instead of the rc variable.

Oh dear. Well, the tools/libxl maintainers are free to keep the new
warnings, and take your fixes, if they wish, clearly needing the help. ;-)

 -- Keir

> Olaf



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel