WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xen

To: Olaf Hering <olaf@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xenstored_core.c
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Sat, 21 May 2011 07:50:15 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Delivery-date: Fri, 20 May 2011 23:51:13 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=5LRPuEx4vNbONFJTZVBA7o6jHrQz5n3jRosKL5ESoIc=; b=spsbl/N6BbM4SCj/guUb6xHcs2ZjNCeDmse8OCjfypQxh4jZzY4vsoQb8mLXw/CK0g pS+/tloxSK6GsFvjWZPAaQ5t5VmPcADAY9+vRVJmUNVERV9n0WdMrKUDyIOdLhC2I7Se rv6Ju/NPyVDJ+yFlAf5GuU3o9/FKgg3b+qYHc=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=D87WsHXTbsMcRSHjLKn6Kfj7GbYGL4BqCiAUPUQww1rAoRcG4Vs4cPp0W700VpZqlA m8VeTvWUqP4h4hQuR5c/ED3alYgDpXl//qqw8M1cJ2xDDV8CyTCvm0yWc0UGzYmw8j7t aPFDERl4Pv18+dMR7h5qOkNJ92A4oJK6Aq7Y8=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110520161133.GA18169@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwXg1a4/9JHiKVitkS17pVY8JFfDQ==
Thread-topic: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xenstored_core.c
User-agent: Microsoft-Entourage/12.29.0.110113
On 20/05/2011 17:11, "Olaf Hering" <olaf@xxxxxxxxx> wrote:

> On Fri, May 20, Keir Fraser wrote:
> 
>> Oh dear. ...
> 
> I think the following patch is good for 4.1 and older, but xen-unstable
> should be fixed (and bugfixes backported) because disabling the warning
> may hide bugs. Is adding the __attribute__ such a burden?

...and the ifdefs? Ugly. And for no bugs fixed so far in the hypervisor. As
I said, I don't maintain the toolstack, those guys can make their own
choice.

 -- Keir


> Olaf
> 
> 
> gcc-4.6 compile fix: build with -Wno-unused-but-set-variable
> 
> Avoid "error: variable 'unused' set but not used
> [-Werror=unused-but-set-variable]"
> with gcc 4.6.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> 
> ---
>  Config.mk |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: xen-unstable.hg-4.2.23363/Config.mk
> ===================================================================
> --- xen-unstable.hg-4.2.23363.orig/Config.mk
> +++ xen-unstable.hg-4.2.23363/Config.mk
> @@ -146,6 +146,7 @@ CFLAGS-$(clang) += -Wno-parentheses -Wno
>  
>  $(call cc-option-add,HOSTCFLAGS,HOSTCC,-Wdeclaration-after-statement)
>  $(call cc-option-add,CFLAGS,CC,-Wdeclaration-after-statement)
> +$(call cc-option-add,CFLAGS,CC,-Wno-unused-but-set-variable)
>  
>  LDFLAGS += $(foreach i, $(EXTRA_LIB), -L$(i))
>  CFLAGS += $(foreach i, $(EXTRA_INCLUDES), -I$(i))



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>