Re: [Xen-devel] [PATCH] xl: fix broken cpupool-numa-split (part

To:	Andre Przywara <andre.przywara@xxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] xl: fix broken cpupool-numa-split (part 2)
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Mon, 31 Jan 2011 07:56:27 +0100
Cc:	George Dunlap <george.dunlap@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date:	Sun, 30 Jan 2011 22:57:28 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1296456991; x=1327992991; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; z=Message-ID:=20<4D465D1B.1010504@xxxxxxxxxxxxxx>\|Date:=20 Mon,=2031=20Jan=202011=2007:56:27=20+0100\|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>\|MIME-Version: =201.0\|To:=20Andre=20Przywara=20<andre.przywara@xxxxxxx> \|CC:=20George=20Dunlap=20<george.dunlap@xxxxxxxxxxxxx>, =20=0D=0A=20"xen-devel@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@ lists.xensource.com>,=0D=0A=20Ian=20Jackson=20<Ian.Jackso n@xxxxxxxxxxxxx>\|Subject:=20Re:=20[Xen-devel]=20[PATCH] =20xl:=20fix=20broken=20cpupool-numa-split=20(part=202) \|References:=20<4D41E547.5000902@xxxxxxx>=20<4D426189.103 0001@xxxxxxxxxxxxxx>=20<4D4360EA.1090807@xxxxxxx> \|In-Reply-To:=20<4D4360EA.1090807@xxxxxxx> \|Content-Transfer-Encoding:=208bit; bh=t8FZsPIo9oIllElVVT55vei6RzJYV0IIsh09xzoz/t4=; b=dBOue6NcqpOqoQaSQDsta5f0zTk/cw9h3dsDtpjTqn7Gt6HijIVU+Wdn e/bZiAzYx5I6LDQfYMHJB2hu89dTAYpH1x5oemDvYTNT68EVJzV7cYd1W 2yboET6ZsoP4H2hAalEJaj0qgF25WnK3x6A2JOYxpn3OWxROE1J9a58U5 wsAUJ4CwY2Clu9FqpuTYPwwYT+2uLwILTIquDdWNY/2socbc57+DhP3ng YRS0TbbQF/zc8A7zEgcb4A4MIUiAI;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=sBxI1qiGZpVPj+Gz7bxfAYDtvD3/NSUaNwt2YSFbFa8RHegONajl1Hv6 wKZYJHU8MUIRedk0Nphr+WgcbTPx1QZYhydeCYmv/xIFn8O1asU0QApF+ UJKQNJsPBsa3WmOK6IEGc4HuowqNjOf1IgOwBhjCsJiVTY3rfzRa4qLT3 eXezc4CYAOIeKl+17WSJs+V8HtoJ0Ac26BVFdbrAhYLmL+7nHYCXuZfiG /DrwyRlRS8wxc/wOIvVGExlmis5SI;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4D4360EA.1090807@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
References:	<4D41E547.5000902@xxxxxxx> <4D426189.1030001@xxxxxxxxxxxxxx> <4D4360EA.1090807@xxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20101226 Iceowl/1.0b1 Icedove/3.0.11

On 01/29/11 01:35, Andre Przywara wrote:

On 01/28/2011 07:26 AM, Juergen Gross wrote:

On 01/27/11 22:36, Andre Przywara wrote:

Hi,

the implementation of xl cpupool-numa-split is broken. It basically
deals with only one poolid, but there are two to consider: the one from
the original root CPUpool, the other from the newly created one.


Uhh, silly copy and paste error! I think it happened when I introduced
libxl_cpupool_cpuadd_node()...
The correction is much easier. The root poolid is always 0.

Why do you save this value then?
poolid = poolinfo[0].poolid;
Reading this made me think it can be an arbitrary value.


Sorry, must be a relict...

See attached patch.

Easier, but that only solves one part of the problem (not populating the
newly created pool). The second bug still persists, because poolid is
not zeroed out again after the first creation. So the second iteration
will try to reuse the just assigned value and abort with an error.

Ian, please apply the attached patch on top of Jürgens one.

----------
Before the creation and population of a new CPU pool we have to clear
the poolid variable, which still contains the value from the previous
iteration.
This fixes the execution of xl cpupool-numa-split on machines with more
than two nodes.

Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>


Acked-by: juergen.gross@xxxxxxxxxxxxxx

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] xl: fix broken cpupool-numa-split (part 2)