 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH]: xl: fix broken cpupool-numa-split
| To: | Juergen Gross <juergen.gross@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH]: xl: fix broken cpupool-numa-split |
| From: | George Dunlap <George.Dunlap@xxxxxxxxxxxxx> |
| Date: | Fri, 28 Jan 2011 10:53:03 +0000 |
| Cc: | Andre Przywara <andre.przywara@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
| Delivery-date: | Fri, 28 Jan 2011 02:53:54 -0800 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=zOvtBFB2bx8QuzaHUTkZ4l6C4gFblPOlllJdchlTU/8=; b=NHBBpzIfZom4oJo1zCFoWRdduBTGaaDMmZFfY1wkVfYq6oq6I/AGLduWeu7BGY68G+ NaljNKAgcnMIiUn+jLbJZMirqvWTobizPV02xfBFrK7RMIBZYdV3JmYrJKWeD8ZPqmxA AELWD9PQloSi1XZSMaWjwp2C5CPJcEH/jDGrE= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=RnuRSntFTu7bmdpGR6bV2i5N9Yk4oQ0bBWWEImKMiApeUy8bIh19QoUYGdiT1oBUKc 1VFcqBwW3DTTtyMnJDzS6whr+H/nuLCp1c2jRW7QjrRGYjmDiCWxUj33DmffN6uxMMt+ MeNRaSFT19Yr78VqDLyaQXy/rDNgS9h2+ciDE= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4D426189.1030001@xxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <4D41E547.5000902@xxxxxxx> <4D426189.1030001@xxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Fri, Jan 28, 2011 at 6:26 AM, Juergen Gross <juergen.gross@xxxxxxxxxxxxxx> wrote: > On 01/27/11 22:36, Andre Przywara wrote: >> >> Hi, >> >> the implementation of xl cpupool-numa-split is broken. It basically >> deals with only one poolid, but there are two to consider: the one from >> the original root CPUpool, the other from the newly created one. > > Uhh, silly copy and paste error! I think it happened when I introduced > libxl_cpupool_cpuadd_node()... > The correction is much easier. The root poolid is always 0. See attached > patch. Re patch itself: Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx> Re the cpupool interface: Hang on; if the root poolid is always 0, why does xc_cpupool_create() interpret a poolid of 0 as "XEN_SYSCTL_CPUPOOL_PAR_ANY"? Doesn't that mean that if you're trying to create a new cpupool from cpus in the root pool, that you might get cpus from other pools? If not, what's the point of the "CPUPOOL_PAR_ANY" parsing? -George _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [Patch] Fixing 1G page allocation algorithm in libxc, George Dunlap |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH]: xl: fix broken cpupool-numa-split, Juergen Gross |
| Previous by Thread: | Re: [Xen-devel] [PATCH]: xl: fix broken cpupool-numa-split, Juergen Gross |
| Next by Thread: | Re: [Xen-devel] [PATCH]: xl: fix broken cpupool-numa-split, Juergen Gross |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
