On 01/28/2011 07:26 AM, Juergen Gross wrote:
On 01/27/11 22:36, Andre Przywara wrote:
Hi,
the implementation of xl cpupool-numa-split is broken. It basically
deals with only one poolid, but there are two to consider: the one from
the original root CPUpool, the other from the newly created one.
Uhh, silly copy and paste error! I think it happened when I introduced
libxl_cpupool_cpuadd_node()...
The correction is much easier. The root poolid is always 0.
Why do you save this value then?
poolid = poolinfo[0].poolid;
Reading this made me think it can be an arbitrary value.
See attached patch.
Easier, but that only solves one part of the problem (not populating the
newly created pool). The second bug still persists, because poolid is
not zeroed out again after the first creation. So the second iteration
will try to reuse the just assigned value and abort with an error.
Ian, please apply the attached patch on top of Jürgens one.
----------
Before the creation and population of a new CPU pool we have to clear
the poolid variable, which still contains the value from the previous
iteration.
This fixes the execution of xl cpupool-numa-split on machines with more
than two nodes.
Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
--
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
xl_fix_numasplit_missing_poolid_reset.patch
Description: xl_fix_numasplit_missing_poolid_reset.patch
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
| 
Home