Re: [Xen-devel] [PATCH]: xl: fix broken cpupool-numa-split

To:	Andre Przywara <andre.przywara@xxxxxxx>
Subject:	Re: [Xen-devel] [PATCH]: xl: fix broken cpupool-numa-split
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Fri, 28 Jan 2011 07:26:17 +0100
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date:	Thu, 27 Jan 2011 22:27:02 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1296195980; x=1327731980; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to; z=Message-ID:=20<4D426189.1030001@xxxxxxxxxxxxxx>\|Date:=20 Fri,=2028=20Jan=202011=2007:26:17=20+0100\|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>\|MIME-Version: =201.0\|To:=20Andre=20Przywara=20<andre.przywara@xxxxxxx> \|CC:=20Ian=20Jackson=20<Ian.Jackson@xxxxxxxxxxxxx>,=20=0D =0A=20"xen-devel@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@lists. xensource.com>\|Subject:=20Re:=20[Xen-devel]=20[PATCH]:=20 xl:=20fix=20broken=20cpupool-numa-split\|References:=20<4D 41E547.5000902@xxxxxxx>\|In-Reply-To:=20<4D41E547.5000902@ amd.com>; bh=YJxskbeRrtU1RGqq8piQ9N49N1eVTjtru70mZY1dcwU=; b=kkEVcqRtbM/Lbty2dUAIYBQ8GnW46GMNIIs65AC6zgPJzTlPCrD4brEe MlLZUB0A/VgbdvHxv+9E+8134B5P6MgSIgOXbl+r2HMrxiHEKwq/Vx6Gg d0tUd58g/wQ4Fo4Y9h3gL75Qbt4Q5OVb3nUi8o8T2BmFtCqH9sm7EvfIN u8iVrFejelK1wo5+OshaDp5EQYau9lH4DblsgbX5bDFtnQCEBFLhZSRaM LHAjDZwTcKfJg3xMiSJ8dkz2Aq6UI;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type; b=s+puFXpPa3QD7F9T5JrZ3EB1RyyUFNnp8jWtFu5KFf1XN+AmLY3EP+eA 0kvBIGxcbP9jzka7JJBfizUcAyQObDJ3dF/WGWSP0NF8lGJJDobEb5r/Y 4QbZ89oI/TO42HHC6G51IMGfZv+wkJ7Ez3YCJR2N6JswXrbV/5knuQXkk mCveqqsZ3/XwPdA5bEAE2DopTZ2Hr9zNO0Uk5KkVWQ0rbMdMUAvGkOg0D 0TGC8kwz3T5TTyjEnQ6259PkKVdTg;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4D41E547.5000902@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
References:	<4D41E547.5000902@xxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20101226 Iceowl/1.0b1 Icedove/3.0.11

On 01/27/11 22:36, Andre Przywara wrote:

Hi,

the implementation of xl cpupool-numa-split is broken. It basically
deals with only one poolid, but there are two to consider: the one from
the original root CPUpool, the other from the newly created one.


Uhh, silly copy and paste error! I think it happened when I introduced
libxl_cpupool_cpuadd_node()...
The correction is much easier. The root poolid is always 0. See attached
patch.


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

cpupool-numa-split-corr.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH]: xl: fix broken cpupool-numa-split