| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH]: minios: don't retrieve the address of void vari
|
To: |
Gianni Tedesco <gianni.tedesco@xxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [PATCH]: minios: don't retrieve the address of void variable |
|
From: |
Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> |
|
Date: |
Fri, 7 Jan 2011 20:29:40 +0100 |
|
Cc: |
Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx> |
|
Delivery-date: |
Fri, 07 Jan 2011 16:05:41 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1294421133.12018.95.camel@xxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Mail-followup-to: |
Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx> |
|
References: |
<1294420140.12018.82.camel@xxxxxxxxxxxxxxxxxxxxxx> <20110107171644.GZ5820@xxxxxxxxxxxxxxxxxxxxxxx> <1294421133.12018.95.camel@xxxxxxxxxxxxxxxxxxxxxx> |
|
Resent-date: |
Sat, 8 Jan 2011 01:04:01 +0100 |
|
Resent-from: |
Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> |
|
Resent-message-id: |
<20110108000401.GT5418@xxxxxxxxxxxxxxxxxxxxxxxxx> |
|
Resent-to: |
xen-devel@xxxxxxxxxxxxxxxxxxx |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.5.12-2006-07-14 |
Gianni Tedesco, le Fri 07 Jan 2011 17:25:33 +0000, a écrit :
> On Fri, 2011-01-07 at 17:16 +0000, Samuel Thibault wrote:
> > Gianni Tedesco, le Fri 07 Jan 2011 17:08:59 +0000, a écrit :
> > > Apparently this is verboten and gcc-4.5 doesn't like it.
> >
> > Damn! I'd say use the struct shared_info instead, since that's what it
> > is.
>
> Fair enough, I was just racing through trying to get it to build so
> didn't have time to stop and smell the roses :)
>
> Thanks for the incredibly prompt review of these by the way.
>
> Gianni
Missing your Signed-off :)
Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> --
>
> diff -r c55b93f3f8cf extras/mini-os/arch/x86/mm.c
> --- a/extras/mini-os/arch/x86/mm.c Fri Jan 07 15:27:30 2011 +0000
> +++ b/extras/mini-os/arch/x86/mm.c Fri Jan 07 17:04:48 2011 +0000
> @@ -281,7 +281,7 @@ static void build_pagetable(unsigned lon
> /*
> * Mark portion of the address space read only.
> */
> -extern void shared_info;
> +extern struct shared_info shared_info;
> static void set_readonly(void *text, void *etext)
> {
> unsigned long start_address =
>
>
--
Samuel
> ±z¬O§_¸g±`¬°¦p¦ó©Ý®i¦æ¾PºÞ¹D¶Ë¸£µ¬?
> ¥Zµn³ø¯È,Âø»x¼s§i©Î¶l±H¢Ò¢Û (Direct Mail)¬O§_¤w¸gµLªk¹F¦¨±z¹w´Áªº¼s§i®ÄªG?
Je vous invite a consulter dans un premier temps le french-Howto.
-+- JCD in Guide du linuxien pervers - "Bien configurer la lisibilité de fcolm"
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home