Re: [Xen-devel] [PATCH]: minios: don't retrieve the address of void variable

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Fri, 2011-01-07 at 17:16 +0000, Samuel Thibault wrote:
> Gianni Tedesco, le Fri 07 Jan 2011 17:08:59 +0000, a écrit :
> > Apparently this is verboten and gcc-4.5 doesn't like it.
> 
> Damn! I'd say use the struct shared_info instead, since that's what it
> is.

Fair enough, I was just racing through trying to get it to build so
didn't have time to stop and smell the roses :)

Thanks for the incredibly prompt review of these by the way.

Gianni

--

diff -r c55b93f3f8cf extras/mini-os/arch/x86/mm.c
--- a/extras/mini-os/arch/x86/mm.c      Fri Jan 07 15:27:30 2011 +0000
+++ b/extras/mini-os/arch/x86/mm.c      Fri Jan 07 17:04:48 2011 +0000
@@ -281,7 +281,7 @@ static void build_pagetable(unsigned lon
 /*
  * Mark portion of the address space read only.
  */
-extern void shared_info;
+extern struct shared_info shared_info;
 static void set_readonly(void *text, void *etext)
 {
     unsigned long start_address =



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel