RE: [Xen-devel] migration fails with option "--live"

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2010-10-25 at 11:24 +0100, Ian Campbell wrote:
> On Mon, 2010-10-25 at 08:04 +0100, Zhang, Yang Z wrote:
> > It was introduced by 22275. 
> 
> Simple thinko on my part, thanks for reporting.
> 
> 8<--------
> 
> # HG changeset patch
> # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> # Date 1288002211 -3600
> # Node ID 3b832cf7c0f4e0c232c8d49be86fd86894f280e3
> # Parent  3f41a2e6b6598df859df64966b39a0d0f6ccad03
> libxc: correct xc_save utility's switch_qemu_logdirty callback return value
> 
> The callback return convention follows xc_domain_save and therefore
> should return 1 on success.

Bah, double confused myself. xc_domain_save returns 0 on success and >0
on error and the callbacks should do the same. Therefore the bug is in
xc_domain_save where it checks the result of the callback...

Will try fixing again after a little testing...

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel