WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] State of gdbsx in xen-4.0-testing.hg and debugger docum

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] State of gdbsx in xen-4.0-testing.hg and debugger documentation.
From: Bruce Edge <bruce.edge@xxxxxxxxx>
Date: Fri, 2 Jul 2010 15:41:06 -0700
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Fri, 02 Jul 2010 15:41:57 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=quJOCpZzNecr7qLoX+SRF2b+jvOI9AvwbeUoOeWg+v8=; b=HLnVyO2b4SNGsVVh9Dfb6q5MxyHiyhkcvjmJJfqSENZNSqGYdg/LVc8qxmmN+6zoDn Y625yDNySCzIsuOfCUizKNYl/mmN17o7UJjETeq8wEZou89DF8F5SZQafndXr3n71SEo rdNrhba2P+DkWT495ANliARCFh0cOq8m3agxY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=wy6VXGSnZkVrZm+uwjpp1bHsV9FQVbpSWDosn0r7wYEBzDy6XoiJ0RXk9eOYHhlg0T YC3D7FAbg5MQDXazzacoo9BAJk1z2HR56DNQBWtBM3LKQH82q64NVyH0P8roDPnHBvcq zPRUNoJNnVsuCYKu21xUM8PC77cyb8eFhR3kM=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19502.6544.743563.733900@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTilqNc_oQ0JmUYUBHLBmNOZ-K8VklsEOEDAHvGlt@xxxxxxxxxxxxxx> <C8534197.19427%keir.fraser@xxxxxxxxxxxxx> <AANLkTimwMvuetvx6LyBvqqWkF-omqjwEvGqmvkKF6OGF@xxxxxxxxxxxxxx> <19502.6544.743563.733900@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, Jul 2, 2010 at 9:53 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
Bruce Edge writes ("Re: [Xen-devel] State of gdbsx in xen-4.0-testing.hg and debugger  documentation."):
> That would simplify the downstream packaging. They wouldn't need to provide
> an additional mechanism/hook/option to get gdbsx installed.
> The current debian packaging patch is a widely used "get this onto my box"
> aid, and it has no facility for tweaking the build options.

Sure.  Please submit a patch to wire it into tools/Makefile, or
wherever is appropriate.

Here is a patch to enable gdbsx by default.

--- xen-4.0-testing.hg-07.02.10/tools/Makefile  2010-07-02 10:30:40.000000000 -0700
+++ xen-4.0-testing.hg/tools/Makefile   2010-07-02 11:25:04.000000000 -0700
@@ -36,6 +36,7 @@
 SUBDIRS-y += libxl
 SUBDIRS-y += remus
 SUBDIRS-$(CONFIG_X86) += xenpaging
+SUBDIRS-y += debugger/gdbsx
 
 # These don't cross-compile
 ifeq ($(XEN_COMPILE_ARCH),$(XEN_TARGET_ARCH))
@@ -134,3 +135,8 @@
                $(MAKE) -C ocaml-xenstored clean; \
        fi
 
+subdir-clean-debugger/gdbsx:
+       $(MAKE) -C debugger/gdbsx clean
+
+subdir-install-debugger/gdbsx:
+       $(MAKE) -C debugger/gdbsx install
--- xen-4.0-testing.hg-07.02.10/xen/Rules.mk    2010-07-02 10:30:41.000000000 -0700
+++ xen-4.0-testing.hg/xen/Rules.mk     2010-07-02 11:58:23.000000000 -0700
@@ -8,7 +8,7 @@
 perfc_arrays  ?= n
 lock_profile  ?= n
 crash_debug   ?= n
-gdbsx         ?= n
+gdbsx         ?= y
 frame_pointer ?= n
 
 XEN_ROOT=$(BASEDIR)/..

------------cut------------

I suppose it would be cleaner to eliminate the debugger dir as gdbsx is the only one under there that's used and that would enable the tools/Rules.mk templates to cover the 
    subdir-clean-gdbsx:
    subdir-install-gdbsx
targets and not require them to be explicit in tools/Makefile

Also, I don't know if 
    SUBDIRS-y += debugger/gdbsx
should be conditional on any type of target, CONFIG_X86 or?

-Bruce
 
Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>