This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel][PATCH] libxc bitmap utils and vcpu-affinity

To: Dulloor <dulloor@xxxxxxxxx>
Subject: Re: [Xen-devel][PATCH] libxc bitmap utils and vcpu-affinity
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 30 Mar 2010 17:27:54 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Tue, 30 Mar 2010 09:28:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <940bcfd21003300905y78754e2cu101055e429a303a1@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrQIte77Jf4612RQiqxEuBXieij0QAAxsaW
Thread-topic: [Xen-devel][PATCH] libxc bitmap utils and vcpu-affinity
User-agent: Microsoft-Entourage/
On 30/03/2010 17:05, "Dulloor" <dulloor@xxxxxxxxx> wrote:

>> It actually bloats the libraries by a net 650 LOC
>> (747 added, 87 deleted according to diffstat).
> In the patch, we have used the library only for vcpu get/set affinity.
> There are clearly other opportunities (right now and in future) to use
> most of the functions provided by the library, which will offset this.
> Also, this provides a cleaner/standard way of using the cpumap
> structure in libxc.

Clearly it's not a simplicity win right now as it net adds a lot of code.
I'd rather see this as part of a patch series that actually uses it more
substantially. And even then I'd bet that half of this patch could be
removed as unused. If NUMA changes end up manipulating cpumaps in, say, a
dozen places then I could see this approach being useful, instead of
pointless abstraction (how it appears currently).

 -- Keir

Xen-devel mailing list