This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Fwd: [Xen-devel][PATCH] libxc bitmap utils and vcpu-affinity

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Fwd: [Xen-devel][PATCH] libxc bitmap utils and vcpu-affinity
From: Dulloor <dulloor@xxxxxxxxx>
Date: Tue, 30 Mar 2010 10:42:18 -0400
Cc: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Tue, 30 Mar 2010 07:43:05 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type; bh=UK062rkarUTnzlbFWneiWunQC5PUUv7ooNpqNj4ZJY0=; b=q4+07ngiFVZ69LRJ8VFE1LUjsBqZnQ0VmSUDcL50HZCa06TVk5vOJS652YnVV+EHMF t1AMCZ2ubQpbGw6/lfsD2Tcdz8K3El1L56tDEnNBM/Z99UfBrYZjBU45ZYpc5aCcfGZi rx2BWFWfEZlCXFF39Y1udtT/f4NgJbASlhtcA=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=WMYOMWAVrgv9e7oY50o6gsv0t5p6oXaKHBYOZsFD+fO0boULgq8lMy9S72cW5LhGWB Q8rRbQZm/pMxP4Hq5yTHoM16GeQzUbGdTe/9+0t+W/7R3njiR02Rfg6jIbw2RqIBCbLX ZB45lGOuHijVoh0MLoRa/VUcaU3f/USXKFOwQ=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <940bcfd21003230955hd15a76di148c140b45ebee8@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BA8A1BC0200007800036662@xxxxxxxxxxxxxxxxxx> <C7CE50F7.E2C9%keir.fraser@xxxxxxxxxxxxx> <940bcfd21003230940w7c7d87eas7e1300cfdb633c4c@xxxxxxxxxxxxxx> <940bcfd21003230941p216c1bb4u60e469d41dda51a@xxxxxxxxxxxxxx> <940bcfd21003230955hd15a76di148c140b45ebee8@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Resubmitting the patch.


---------- Forwarded message ----------
From: Dulloor <dulloor@xxxxxxxxx>
Date: Tue, Mar 23, 2010 at 12:55 PM
Subject: Re: [Xen-devel][PATCH] libxc bitmap utils and vcpu-affinity
To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Cc: Jan Beulich <JBeulich@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx"

Please use this patch, in which length of bitmap is
(physinfo.max_cpu_id+1), rather than (physinfo.nr_cpus).


On Tue, Mar 23, 2010 at 12:41 PM, Dulloor <dulloor@xxxxxxxxx> wrote:
> I meant utils for **xenctl_cpumap**
> On Tue, Mar 23, 2010 at 12:40 PM, Dulloor <dulloor@xxxxxxxxx> wrote:
>> Fine, I agree with you both. Attached is a patch adding utils for
>> xenctl_bitmap (to libxc) and using the same in vcpu_(get|set)affinity.
>> For the guest-numa interface, I will see if I can use xenctl_cpumap.
>> -dulloor
>> On Tue, Mar 23, 2010 at 7:05 AM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 
>> wrote:
>>> On 23/03/2010 10:10, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>>>>>>> Dulloor <dulloor@xxxxxxxxx> 22.03.10 18:44 >>>
>>>>> Motivation for using xenctl_cpumask in Xen interfaces :
>>>>> - xenctl_cpumap is just 4 bytes smaller than static xenctl_cpumask for
>>>>> 128 cpus (128 would be good for quite some time). However, the new
>>>> I don't buy this (we're already building for 256 CPUs, looking forward
>>>> to further bump this in the not too distant future), and I'm generally
>>>> opposed to introducing hard coded limits in a public interface.
>>> We should use xenctl_cpumask everywhere for specifying physical CPU bitmaps,
>>> even into guest NUMA interfaces if appropriate. I don't really care if it is
>>> a bit harder to use than a static bitmap.
>>>  -- Keir

Attachment: cpumap-utils.patch
Description: Text Data

Xen-devel mailing list