This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel][PATCH] libxc bitmap utils and vcpu-affinity

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel][PATCH] libxc bitmap utils and vcpu-affinity
From: Dulloor <dulloor@xxxxxxxxx>
Date: Tue, 23 Mar 2010 12:55:47 -0400
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Tue, 23 Mar 2010 09:56:47 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=PhuZqYo3PezJ8BVPtYGj9fLsXSLCcEXIg0pFLbTj9qQ=; b=FMhNkTu9GkfvUNN/TDqQxmePg1eyDW7GqI5gweHYv+coxlireJrG1SicE7PxSVrfFz QmE8EC0pbiRCC8k5SxMPTKCilWvx7uAm1/WtEKYJBRmQt7qHHtWoZVu5WYxphydjB6G+ h2x9AUkG4pVtS+DNgDs5wKeu3W14qoxOAYNUA=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=RIj/S7WIDHF6Ty6bW79/zek0cZ+dtlWfdiRonr2NQ4YD18pIym9xwbMBWe3nAqqieK stmgZAZ5H9LszAAyg1xmNSj5rdm1V83xPEyMRW/MQffkDzb+MRnps6auOzJYi+IJ/wP+ QC5qx+pbIBE/x43C/w1L4eDcD2xAyZzHyAcaw=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <940bcfd21003230941p216c1bb4u60e469d41dda51a@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BA8A1BC0200007800036662@xxxxxxxxxxxxxxxxxx> <C7CE50F7.E2C9%keir.fraser@xxxxxxxxxxxxx> <940bcfd21003230940w7c7d87eas7e1300cfdb633c4c@xxxxxxxxxxxxxx> <940bcfd21003230941p216c1bb4u60e469d41dda51a@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Please use this patch, in which length of bitmap is
(physinfo.max_cpu_id+1), rather than (physinfo.nr_cpus).


On Tue, Mar 23, 2010 at 12:41 PM, Dulloor <dulloor@xxxxxxxxx> wrote:
> I meant utils for **xenctl_cpumap**
> On Tue, Mar 23, 2010 at 12:40 PM, Dulloor <dulloor@xxxxxxxxx> wrote:
>> Fine, I agree with you both. Attached is a patch adding utils for
>> xenctl_bitmap (to libxc) and using the same in vcpu_(get|set)affinity.
>> For the guest-numa interface, I will see if I can use xenctl_cpumap.
>> -dulloor
>> On Tue, Mar 23, 2010 at 7:05 AM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 
>> wrote:
>>> On 23/03/2010 10:10, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>>>>>>> Dulloor <dulloor@xxxxxxxxx> 22.03.10 18:44 >>>
>>>>> Motivation for using xenctl_cpumask in Xen interfaces :
>>>>> - xenctl_cpumap is just 4 bytes smaller than static xenctl_cpumask for
>>>>> 128 cpus (128 would be good for quite some time). However, the new
>>>> I don't buy this (we're already building for 256 CPUs, looking forward
>>>> to further bump this in the not too distant future), and I'm generally
>>>> opposed to introducing hard coded limits in a public interface.
>>> We should use xenctl_cpumask everywhere for specifying physical CPU bitmaps,
>>> even into guest NUMA interfaces if appropriate. I don't really care if it is
>>> a bit harder to use than a static bitmap.
>>>  -- Keir

Attachment: cpumap-utils.patch
Description: Text Data

Xen-devel mailing list