|
xen-devel
[Xen-devel] Re: [PATCH 17/17] xen: disable MSI
|
To: |
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH 17/17] xen: disable MSI |
|
From: |
Ingo Molnar <mingo@xxxxxxx> |
|
Date: |
Wed, 27 May 2009 23:18:28 +0200 |
|
Cc: |
Chris Wright <chrisw@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ky Srinivasan <ksrinivasan@xxxxxxxxxx>, kurt.hackel@xxxxxxxxxx, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Avi Kivity <avi@xxxxxxxxxx>, Jens Axboe <jens.axboe@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Greg KH <gregkh@xxxxxxx> |
|
Delivery-date: |
Wed, 27 May 2009 14:19:09 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<alpine.LFD.2.01.0905270829530.3435@xxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<1243409850-21577-1-git-send-email-jeremy@xxxxxxxx> <1243409850-21577-18-git-send-email-jeremy@xxxxxxxx> <alpine.LFD.2.01.0905270829530.3435@xxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, 27 May 2009, Jeremy Fitzhardinge wrote:
> >
> > [ Impact: prevent MSI subsystem from crashing ]
>
> Grr.
>
> I looked at several of these impact lines, and they were _all_ totally
> misleading.
>
> Please, guys. Stop with the F*CKING impact lines already. Add them
> if they are obvious, but don't make them this idiotic "do an
> impact line whether or not it makes sense".
>
> I hate them. They are stupid. 90% of all the impact lines I see
> are either (a) misleading or (b) totally inane and pointless.
>
> In this case, we would have been a LOT BETTER OFF with having just
> a better header line that said "xen: disable MSI to avoid crash"
> or something like that. But no. THAT F*CKING IMPACT LINE
> apparently meant that Jeremy just turned off his brain, and made
> _both_ the header line and the Impact: line be non-descriptive.
>
> Really. Stop it. Ingo, start saying "no" to people, at least for
> impact lines that do not make sense. It adds _nothing_, and it
> actually detracts from real content, because just the inanity of
> them delutes the whole meaning of it.
hm, i have to concur. Too often it ends up splitting attention away
from the title of the commit. I do reject (or fix up) bad impact
lines - will stop doing them altogether if you think there's a net
downside to them ...
Ingo
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home