xen-devel
[Xen-devel] [PATCH 12/17] xen: use acpi_get_override_irq() to get trigge
To: |
Ingo Molnar <mingo@xxxxxxx> |
Subject: |
[Xen-devel] [PATCH 12/17] xen: use acpi_get_override_irq() to get triggering for legacy irqs |
From: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
Date: |
Wed, 27 May 2009 00:37:25 -0700 |
Cc: |
Chris Wright <chrisw@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ky Srinivasan <ksrinivasan@xxxxxxxxxx>, kurt.hackel@xxxxxxxxxx, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Avi Kivity <avi@xxxxxxxxxx>, Jens Axboe <jens.axboe@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Greg KH <gregkh@xxxxxxx> |
Delivery-date: |
Wed, 27 May 2009 00:53:56 -0700 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<1243409850-21577-1-git-send-email-jeremy@xxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
References: |
<1243409850-21577-1-git-send-email-jeremy@xxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
From: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
We need to set up proper IO apic entries for legacy irqs, which are
not normally configured by either normal acpi interrupt routing or
PNP.
This also generalizes the acpi interrupt setup, so we can remove it
as a special case.
[ Impact: compatibility with legacy/ISA hardware ]
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
---
arch/x86/xen/pci.c | 24 ++++++++++--------------
1 files changed, 10 insertions(+), 14 deletions(-)
diff --git a/arch/x86/xen/pci.c b/arch/x86/xen/pci.c
index 00ad6df..db0c74c 100644
--- a/arch/x86/xen/pci.c
+++ b/arch/x86/xen/pci.c
@@ -65,19 +65,15 @@ void __init xen_setup_pirqs(void)
{
int irq;
-#ifdef CONFIG_ACPI
- /*
- * Set up acpi interrupt in acpi_gbl_FADT.sci_interrupt.
- */
- if (acpi_gbl_FADT.sci_interrupt > 0) {
- irq = xen_allocate_pirq(acpi_gbl_FADT.sci_interrupt);
-
- printk(KERN_INFO "xen: allocated irq %d for acpi %d\n",
- irq, acpi_gbl_FADT.sci_interrupt);
- }
-#endif
-
/* Pre-allocate legacy irqs */
- for (irq = 0; irq < NR_IRQS_LEGACY; irq++)
- xen_allocate_pirq(irq);
+ for (irq = 0; irq < NR_IRQS_LEGACY; irq++) {
+ int trigger, polarity;
+
+ if (acpi_get_override_irq(irq, &trigger, &polarity) == -1)
+ continue;
+
+ xen_register_gsi(irq,
+ trigger ? ACPI_LEVEL_SENSITIVE : ACPI_EDGE_SENSITIVE,
+ polarity ? ACPI_ACTIVE_LOW : ACPI_ACTIVE_HIGH);
+ }
}
--
1.6.0.6
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
<Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] [PATCH 01/17] xen/dom0: handle acpi lapic parsing in Xen dom0, (continued)
- [Xen-devel] [PATCH 01/17] xen/dom0: handle acpi lapic parsing in Xen dom0, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 03/17] xen: implement io_apic_ops, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 02/17] x86: add io_apic_ops to allow interception, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 06/17] x86/io_apic: add get_nr_irqs_gsi(), Jeremy Fitzhardinge
- [Xen-devel] [PATCH 05/17] xen: implement pirq type event channels, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 07/17] xen/apic: identity map gsi->irqs, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 10/17] xen: pre-initialize legacy irqs early, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 11/17] xen: don't setup acpi interrupt unless there is one, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 13/17] xen: initialize irq 0 too, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 08/17] xen: direct irq registration to pirq event channels, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 12/17] xen: use acpi_get_override_irq() to get triggering for legacy irqs,
Jeremy Fitzhardinge <=
- [Xen-devel] [PATCH 15/17] xen: set pirq name to something useful., Jeremy Fitzhardinge
- [Xen-devel] [PATCH 16/17] xen: fix legacy irq setup, make ioapic-less machines work., Jeremy Fitzhardinge
- [Xen-devel] [PATCH 09/17] xen: bind pirq to vector and event channel, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 14/17] xen: dynamically allocate irq & event structures, Jeremy Fitzhardinge
- [Xen-devel] [PATCH 17/17] xen: disable MSI, Jeremy Fitzhardinge
|
|
|