|
xen-devel
[Xen-devel] Re: [PATCH 17/17] xen: disable MSI
|
To: |
Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH 17/17] xen: disable MSI |
|
From: |
Roland Dreier <rdreier@xxxxxxxxx> |
|
Date: |
Wed, 27 May 2009 15:03:42 -0700 |
|
Authentication-results: |
sj-dkim-4; header.From=rdreier@xxxxxxxxx; dkim=pass ( sig from cisco.com/sjdkim4002 verified; ); |
|
Cc: |
Chris Wright <chrisw@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Ky Srinivasan <ksrinivasan@xxxxxxxxxx>, kurt.hackel@xxxxxxxxxx, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Avi Kivity <avi@xxxxxxxxxx>, Jens Axboe <jens.axboe@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Greg KH <gregkh@xxxxxxx> |
|
Delivery-date: |
Thu, 28 May 2009 06:28:36 -0700 |
|
Dkim-signature: |
v=1; a=rsa-sha256; q=dns/txt; l=1544; t=1243461823; x=1244325823; c=relaxed/simple; s=sjdkim4002; h=Content-Type:From:Subject:Content-Transfer-Encoding:MIME-Version; d=cisco.com; i=rdreier@xxxxxxxxx; z=From:=20Roland=20Dreier=20<rdreier@xxxxxxxxx> |Subject:=20Re=3A=20[PATCH=2017/17]=20xen=3A=20disable=20MS I |Sender:=20; bh=C8ho2s/LMjMZJgOa8kTqZcFdx23SEQRSnjagFca+3pE=; b=KLviE7aeiQ9wbfqOm53/Xw7H0ey9jX2rQaMRSCJeBbLhBr1ONGGBXD+AVw BMaI/y3QUy1fJ6RZOs8FZXZhcUMueOh1tFWS4uv8b+z61DIK3iw7y7GcZzYi ZUbC/p04U6; |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<alpine.LFD.2.01.0905271436140.3435@xxxxxxxxxxxxxxxxxxxxx> (Linus Torvalds's message of "Wed, 27 May 2009 14:46:15 -0700 (PDT)") |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<1243409850-21577-1-git-send-email-jeremy@xxxxxxxx> <1243409850-21577-18-git-send-email-jeremy@xxxxxxxx> <alpine.LFD.2.01.0905270829530.3435@xxxxxxxxxxxxxxxxxxxxx> <20090527211828.GA6166@xxxxxxx> <alpine.LFD.2.01.0905271436140.3435@xxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) |
> Pu another way: if they actually add value in highlighting the commits
> that _should_ stand out, then hey, by all means, keep such ones. I would
> not at all object if it was an issue of
>
> [ Impact: fix bugzilla entry 455123 ]
I wonder if it's really worth having such a visually distinctive style
for tagging things that fix bugzilla entries. I've been just writing
out in English the bug information -- eg a recent changelog contains
This patch fixes <https://bugs.openfabrics.org/show_bug.cgi?id=1571>,
an NFS/RDMA server crash.
I could see adding a tag along the lines of tested-by, reported-by,
reviewed-by, etc. Maybe something like
Closes-bug: <URL>
so the above language would become
Closes-bug: https://bugs.openfabrics.org/show_bug.cgi?id=1571
And then "git log|grep 'Closes-bug:'" or "git log|grep '<bug URL>'"
becomes interesting...
> [ Impact: fix user-triggerable oops ]
This I think gets close to the never-ending argument about tagging
"security" bugs. It might not be obvious immediately that a given
change fixes a user-triggerable oops and grepping the log for commits
that claim to fix a certain type of problem is quite likely to miss some
such fixes.
In the case where I know that a commit *does* fix a user-triggerable
oops, I try to note it in the changelog by saying, "This fixes an oops
that can be triggered by a user passing in garbage input xyz..." but I'm
not sure if we want to put that in a standardized greppable form.
- R.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home