Re: [Xen-devel] 32-on-64: pvfb issue

[Markus Armbruster <armbru@xxxxxxxxxx>]

Gerd Hoffmann <kraxel@xxxxxxx> writes:

[...]
> The pvfb backend has a stupid tyops (missing underscore) which breaks
> the combination 32bit dom0 and 64bit domU.  Fix attached.  The patch
> also adds a cast to fix a warning.
>
> please apply,
>
>   Gerd
>
> -- 
> Gerd Hoffmann <kraxel@xxxxxxx>
> Index: build-32-release304-13133/tools/xenfb/xenfb.c
> ===================================================================
> --- build-32-release304-13133.orig/tools/xenfb/xenfb.c
> +++ build-32-release304-13133/tools/xenfb/xenfb.c
[...]
> @@ -560,10 +560,10 @@ int xenfb_attach_dom(struct xenfb *xenfb
>       if (xenfb_wait_for_frontend_initialised(&xenfb->kbd) < 0)
>               goto error;
>  
> -     if (xenfb_bind(&xenfb->fb) < 0)
> -             goto error;
>       if (xenfb_bind(&xenfb->kbd) < 0)
>               goto error;
> +     if (xenfb_bind(&xenfb->fb) < 0)
> +             goto error;
>  
>       if (xenfb_xs_scanf1(xsh, xenfb->fb.otherend, "feature-update",
>                           "%d", &val) < 0)

Why is this patch hunk necessary?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel