 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Add -Wcast-qual flag
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Add -Wcast-qual flag |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | Thu, 21 Dec 2006 13:28:10 +0000 |
| Delivery-date: | Thu, 21 Dec 2006 05:28:19 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <458A915B.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcclA9tvGfOI8pD3EduxsQAX8io7RQ== |
| Thread-topic: | [Xen-devel] [PATCH] Add -Wcast-qual flag |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 21/12/06 12:51, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > While I'd really like to see all Xen code become const-correct (because I do > believe this helps with code quality, like does marking read only data read > only in the page tables), I don't think adding the warning here is > appropriate - after all, in C this is one of the purposes of adding explicit > casts (although I agree it's questionable to use casts for this purpose). > And no, I don't think that many people screwing up const placement is a > proper argument for not using const where possible. Well, I'm inclined to take the clean-up parts of the patches but leave out __UNCONST() and -Wcast-qual. I really dislike the compiler thinking it knows better than an explicit cast, and casting via unsigned long is just a kludge. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] Unmatched decrementing of net device reference count, Glauber de Oliveira Costa |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] Add -Wcast-qual flag, Christoph Egger |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Add -Wcast-qual flag, Jan Beulich |
| Next by Thread: | Re: [Xen-devel] [PATCH] Add -Wcast-qual flag, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
