Re: [Xen-devel] [PATCH] Add -Wcast-qual flag

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>>> Keir Fraser <keir@xxxxxxxxxxxxx> 21.12.06 14:28 >>>
>On 21/12/06 12:51, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>> While I'd really like to see all Xen code become const-correct (because I do
>> believe this helps with code quality, like does marking read only data read
>> only in the page tables), I don't think adding the warning here is
>> appropriate - after all, in C this is one of the purposes of adding explicit
>> casts (although I agree it's questionable to use casts for this purpose).
>> And no, I don't think that many people screwing up const placement is a
>> proper argument for not using const where possible.
>
>Well, I'm inclined to take the clean-up parts of the patches but leave out
>__UNCONST() and -Wcast-qual. I really dislike the compiler thinking it knows
>better than an explicit cast, and casting via unsigned long is just a
>kludge.

This I completely agree with.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel