WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Add -Wcast-qual flag

To: Christoph Egger <Christoph.Egger@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Add -Wcast-qual flag
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 21 Dec 2006 10:41:53 +0000
Delivery-date: Thu, 21 Dec 2006 02:42:35 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200612211105.21248.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acck7KCu33GVOpDfEduxsQAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Add -Wcast-qual flag
User-agent: Microsoft-Entourage/11.2.5.060620
On 21/12/06 10:05, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> The xen-cast.diff adds the -Wcast-qual flag.

We don't enable this flag precisely because we end up needing to scatter
const all over the place like confetti. I'm not convinced that use of const
improves code quality. I fear we'd end up with 'const foo * const bar' all
over the place -- ugly and confusing to most programmers (who frequently
mess up const placement, in my experience).

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel