WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Unmatched decrementing of net device reference c

To: Herbert Xu <herbert.xu@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Unmatched decrementing of net device reference count
From: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>
Date: Thu, 21 Dec 2006 11:02:20 -0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir@xxxxxxxxxxxxx>
Delivery-date: Thu, 21 Dec 2006 05:01:32 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061221124024.GA6043@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061221084932.GA4471@xxxxxxxxxxxxxxxxxxx> <C1B01A96.6B02%keir@xxxxxxxxxxxxx> <20061221124024.GA6043@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11
On Thu, Dec 21, 2006 at 11:40:24PM +1100, Herbert Xu wrote:
> On Thu, Dec 21, 2006 at 11:03:50AM +0000, Keir Fraser wrote:
> > On 21/12/06 08:49, "Herbert Xu" <herbert.xu@xxxxxxxxxx> wrote:
> > 
> > > Thanks for the explanation.  I understand the problem now.  However,
> > > I think your patch isn't adequate because the closing of the backend
> > > no longer shuts down the transmitter in the frontend.
> > 
> > Changeset 13100:e99ba0c6c is what I checked in to fix this issue. I think it
> > goes far enough, but please do take a look and check.
> 
> Yes it's OK for now because the frontend doesn't hold any resources
> from the backend.  So even if the frontend tries to xmit after the
> backend starts closing, it won't cause any problems.
 
It indeed looks sane, and passes my tests.

Thanks!

-- 
Glauber de Oliveira Costa
Red Hat Inc.
"Free as in Freedom"

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel