WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] 1 of 2: default ssid to 0

To: Reiner Sailer <sailer@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 1 of 2: default ssid to 0
From: aq <aquynh@xxxxxxxxx>
Date: Sun, 26 Jun 2005 19:04:54 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Stefan Berger <stefanb@xxxxxxxxxx>
Delivery-date: Sun, 26 Jun 2005 10:03:49 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=ddIeIdkb8BbsECsDWwGbt/MvKVIgMoUehjgu0uZsyN+zMej5OjIq3bVmcvWxLoX4HFI0Vv+EZGjtb+PR/MtIhHz7CM9IF4t3/UAOoljRba0Bvm53Si8J0yXMnVnpOa1K01sLb3Mnj7S4iEW0CUn4kd7Tp3HgQ/jmpmbhSQwi3bs=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <OF925F6D60.79986553-ON8525702C.0012218A-8525702C.001254CB@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <OF925F6D60.79986553-ON8525702C.0012218A-8525702C.001254CB@xxxxxxxxxx>
Reply-to: aq <aquynh@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 6/26/05, Reiner Sailer <sailer@xxxxxxxxxx> wrote:
> > Message: 7
> > Date: Sat, 25 Jun 2005 20:39:20 -0500
> > From: aq <aquynh@xxxxxxxxx>
> > Subject: Re: [Xen-devel] [PATCH] 1 of 2: default ssid to 0
> > To: Stefan Berger <stefanb@xxxxxxxxxx>
> > Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> > Message-ID: <9cde8bff05062518394eab73cb@xxxxxxxxxxxxxx>
> > Content-Type: text/plain; charset=ISO-8859-1
> >
> > On 6/25/05, Stefan Berger <stefanb@xxxxxxxxxx> wrote:
> > > Hello!
> > >
> > > Attached is the patch that changes the default ssid from 0xffffffff to
> 0
> > > as discussed in previous emails.
> > >
> > > Signed-off-by: Reiner Sailer <sailer@xxxxxxxxxx>
> > > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>
> > >
> > >    Stefan
> > >
> >
> >
> >
> > +     for(j=0; j<= CWALL_MAX_SSIDREFS; j++)
> > +         if ((0 < j) &&( j <= CWALL_MAX_TYPES))
> > +             ssidrefs[j*CWALL_MAX_TYPES + j - 1] = htons(1);
> > +
> >
> > why dont you run the loop from j=1?
> 
> 
> because row j=0 is the new default ssid and has no types set.
> We start with row j=1 and set the "diagonal" types to one.

i meant in the above loop, if start from j=1 you can eliminate the
check (if 0<j), because in case j=0 you does nothing.

regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel