This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH -v3 -resend] watchdog, SP5100: Check if firmware

To: Yinghai Lu <yinghai@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH -v3 -resend] watchdog, SP5100: Check if firmware has set correct value in tcobase.
From: Wim Van Sebroeck <wim@xxxxxxxxx>
Date: Thu, 24 Mar 2011 09:31:20 +0100
Cc: Priyanka Gupta <priyankag@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, linux-watchdog@xxxxxxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Mike Waychison <mikew@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 24 Mar 2011 01:32:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D8AD791.9010602@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110311222129.GA3168@xxxxxxxxxxxx> <alpine.DEB.2.00.1103161150010.3382@kaball-desktop> <alpine.DEB.2.00.1103161442210.3382@kaball-desktop> <4D80F992.10603@xxxxxxxxxx> <alpine.DEB.2.00.1103161757040.3382@kaball-desktop> <4D812180.5030102@xxxxxxxxxx> <AANLkTimNva3c_-kGA+JLCPZgrKAbwqLKaN559cwTh7cq@xxxxxxxxxxxxxx> <4D812919.30706@xxxxxxxxxx> <20110317022331.GA3528@xxxxxxxxxxxx> <4D8AD791.9010602@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
Hi Yinghai,

> Stefano found SP5100 TCO watchdog driver using wrong address.
> [    9.148536] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01
> [    9.148628] DEBUG __ioremap_caller WARNING address=b8fe00 size=8 valid=1 
> reserved=1
> and e820 said that range is RAM.
> We should check if we can use that reading out. BIOS could just program wrong 
> address there.
> -v2: Mike pointed out one path need one release.
> -v3: corrected logic checking with request_mem_region_exclusive()
>      Found by Konrad.
> Reported-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Signed-off-by:Yinghai Lu <yinghai@xxxxxxxxxx>
> Acked-by: Mike Waychison <mikew@xxxxxxxxxx>
> Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

This patch is in linux-2.6-watchdog-next for a week now. Will go upstream to 

Kind regards,

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>